Skip to content

[lldb] Update for removal of ModuleDecl::addFile #9618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hamishknight
Copy link

@hamishknight hamishknight commented Nov 16, 2024

This requires plumbing `PopulateFilesFn` through
`SwiftASTContext::CreateModule`.
@hamishknight hamishknight changed the title [DNM] [lldb] Update for removal of ModuleDecl::addFile [lldb] Update for removal of ModuleDecl::addFile Nov 17, 2024
@hamishknight hamishknight marked this pull request as ready for review November 18, 2024 09:51
@hamishknight
Copy link
Author

swiftlang/swift#77666

@swift-ci please test

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this PR on swift/release/6.1?

@hamishknight
Copy link
Author

@adrian-prantl This is targeting main, it doesn't need to be in 6.1

@adrian-prantl adrian-prantl self-requested a review November 21, 2024 18:55
Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case LGTM — please don't forget to also create a matching PR that cherry-picks this to next!

@adrian-prantl
Copy link

You can/should merge the next cherry-pick immediately without review or testing.

@hamishknight hamishknight merged commit acc849b into swiftlang:stable/20240723 Nov 21, 2024
3 checks passed
@hamishknight hamishknight deleted the lets-try-this-again branch November 21, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants