-
Notifications
You must be signed in to change notification settings - Fork 341
[lldb] Update for removal of ModuleDecl::addFile
#9618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lldb] Update for removal of ModuleDecl::addFile
#9618
Conversation
ea575f1
to
99fb04f
Compare
This requires plumbing `PopulateFilesFn` through `SwiftASTContext::CreateModule`.
99fb04f
to
e227a8f
Compare
ModuleDecl::addFile
ModuleDecl::addFile
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase this PR on swift/release/6.1?
@adrian-prantl This is targeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case LGTM — please don't forget to also create a matching PR that cherry-picks this to next
!
You can/should merge the next cherry-pick immediately without review or testing. |
Update for swiftlang/swift#77666