[AST] Remove ModuleDecl::addFile
#77666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 16, 2024
hamishknight
force-pushed
the
lets-try-this-again
branch
2 times, most recently
from
7cadaf9 to
67ba133
Compare
hamishknight
changed the title
ModuleDecl::addFileModuleDecl::addFile
This resolves imports for the entire module.
We shouldn't be attempting to append SourceFiles to the module after-the-fact for syntactic macro expansion, refactor things such that the SourceFile is created alongside the ModuleDecl.
Rather than exposing an `addFile` member on ModuleDecl, have the `create` members take a lambda that populates the files for the module. Once module construction has finished, the files are immutable.
hamishknight
force-pushed
the
lets-try-this-again
branch
from
67ba133 to
4946c79
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
hamishknight
requested review from
hborla,
xedin,
slavapestov,
ahoppen,
bnbarham,
rintaro,
artemcm,
xymus,
CodaFi,
DougGregor,
rjmccall,
tshortli,
adrian-prantl,
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please test |
rintaro
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than exposing an
addFilemember on ModuleDecl, have thecreatemembers take a lambda that populates the files for the module. Once module construction has finished, the files are immutable.