[lldb] Introduce an ImportedDeclaration and [lldb] Handle @_originallyDefinedIn [main] #9745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusto2112
force-pushed
the
orig-defined-in-imported-decl
branch
from
d4feeb5 to
da03971
Compare
augusto2112
force-pushed
the
orig-defined-in-imported-decl
branch
from
da03971 to
d4b312d
Compare
1 similar comment
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
|
|
||
| static NodePointer CloneNode(Demangler &dem, NodePointer node, | ||
| bool set_children = true) { | ||
| NodePointer clone; |
There was a problem hiding this comment.
Should this be in the demangle helper functions file?
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
augusto2112
force-pushed
the
orig-defined-in-imported-decl
branch
from
d4b312d to
6ecec18
Compare
augusto2112
force-pushed
the
orig-defined-in-imported-decl
branch
from
6ecec18 to
e8a1614
Compare
augusto2112
force-pushed
the
orig-defined-in-imported-decl
branch
from
e8a1614 to
daed161
Compare
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
Introduce a debug info independent type, ImportedDeclaration, which is analogous to DWARF's DW_AT_imported_declaration, as well as a way to search them by name.
augusto2112
force-pushed
the
orig-defined-in-imported-decl
branch
from
daed161 to
6621535
Compare
adrian-prantl
approved these changes
Dec 17, 2024
Types annotated with @_originallyDefinedIn don't live in the module listed in their mangled name. To account for this, the compiler emits a DW_TAG_imported_declaration for those types under the name of the swiftmodule these types can be found at. This patch implements the logic required to produce the mangled name that can be used in type reconstruction to successfully find these types. rdar://137146961
augusto2112
force-pushed
the
orig-defined-in-imported-decl
branch
from
6621535 to
ce1a9d5
Compare
1 similar comment
|
Unrelated Windows failure: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits:
[lldb] Introduce an ImportedDeclaration
Introduce a debug info independent type, ImportedDeclaration, which is
analogous to DWARF's DW_AT_imported_declaration, as well as a way to
search them by name.
[lldb] Handle @_originallyDefinedIn
Types annotated with @_originallyDefinedIn don't live in the module
listed in their mangled name. To account for this, the compiler emits a
DW_TAG_imported_declaration for those types under the name of the
swiftmodule these types can be found at. This patch implements the logic
required to produce the mangled name that can be used in type
reconstruction to successfully find these types.
rdar://137146961