[lldb] Introduce an ImportedDeclaration and [lldb] Handle @_originallyDefinedIn #9657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2024
Introduce a debug info independent type, ImportedDeclaration, which is analogous to DWARF's DW_AT_imported_declaration, as well as a way to search them by name.
Types annotated with @_originallyDefinedIn don't live in the module listed in their mangled name. To account for this, the compiler emits a DW_TAG_imported_declaration for those types under the name of the swiftmodule these types can be found at. This patch implements the logic required to produce the mangled name that can be used in type reconstruction to successfully find these types. rdar://137146961
augusto2112
force-pushed
the
orig-def-in-imported-decl-6
branch
from
47f104b to
b9f47ba
Compare
| /// \param[in] find_one | ||
| /// If set to true, the search will stop after the first imported | ||
| /// declaration is found. | ||
| void FindImportedDeclarations(ConstString name, |
There was a problem hiding this comment.
This API should probably exist upstream, too.
| /// If set to true, the search will stop after the first imported | ||
| /// declaration is found. | ||
| void FindImportedDeclarations(ConstString name, | ||
| std::vector<ImportedDeclaration> &results, |
There was a problem hiding this comment.
Unless you need to append to the same vector multiple times, it should probably be a return type.
There was a problem hiding this comment.
You do append to the vector multiple times as part of the implementation (for example on SymbolFileDWARFDebugMap). This is also how all of the other query APIs in Module and SymbolFile do it, so I'd rather keep it this way to stay consistent.
| @@ -0,0 +1,18 @@ | |||
| //===-- Symbol.cpp --------------------------------------------------------===// | |||
|
Closed in favor of #9745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits:
[lldb] Introduce an ImportedDeclaration
Introduce a debug info independent type, ImportedDeclaration, which is
analogous to DWARF's DW_AT_imported_declaration, as well as a way to
search them by name.
[lldb] Handle @_originallyDefinedIn
Types annotated with @_originallyDefinedIn don't live in the module
listed in their mangled name. To account for this, the compiler emits a
DW_TAG_imported_declaration for those types under the name of the
swiftmodule these types can be found at. This patch implements the logic
required to produce the mangled name that can be used in type
reconstruction to successfully find these types.
rdar://137146961