[DebugInfo] Fix handling of @_originallyDefinedIn types #77779
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
reviewed
Nov 21, 2024
slavapestov
reviewed
Nov 21, 2024
augusto2112
force-pushed
the
orig-def-in-imported-decl-6
branch
from
d401976 to
98fb153
Compare
|
@swift-ci test |
augusto2112
force-pushed
the
orig-def-in-imported-decl-6
branch
from
98fb153 to
5ea0bec
Compare
|
@swift-ci test |
augusto2112
force-pushed
the
orig-def-in-imported-decl-6
branch
from
5ea0bec to
e0ce718
Compare
augusto2112
commented
Nov 22, 2024
| /// Returns true if the type's mangled name is affected by an | ||
| /// @_originallyDefinedIn annotation. This annotation can be on the type | ||
| /// itself, one of its generic arguments, etc. | ||
| bool containsOriginallyDefinedIn(Type T) { |
There was a problem hiding this comment.
@slavapestov I found the following situations where @_originallyDefinedIn could affect a type's mangled name:
- The type itself being annotated.
- The bound generic arguments being annotated.
- A typealias local to a function could be affected by the types in the function's generic signature.
- A metatype's type.
Do you know of any other ones?
Emit an imported declaration for @_originallyDefinedIn under the real module that these types live in. This patch also changes the mangling for the debugger to respect @_originallyDefinedIn, and fixes a bug where @_originallyDefinedIn that should be ignored was still being used when mangling. rdar://137146961
augusto2112
force-pushed
the
orig-def-in-imported-decl-6
branch
from
e0ce718 to
43c420e
Compare
|
swiftlang/llvm-project#9657 |
| if (auto *MT = llvm::dyn_cast<MetatypeType>(T)) | ||
| if (containsOriginallyDefinedIn(MT->getInstanceType())) | ||
| return true; | ||
| ; |
|
|
||
| // If the type is a bound generic, the type of the substituted generic | ||
| // arguments might be annotated with @_originallyDefinedIn. | ||
| if (auto *BGT = llvm::dyn_cast<BoundGenericType>(T)) |
There was a problem hiding this comment.
I would have expected this function to be implemented in terms of a type visitor. For example, does this catch a a tuple containing an originallyDefinedIn type?
|
@swift-ci test source compatibility |
|
Closed in favor of #78104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.