Skip to content

[ThinLTO][Cache] When remote caching is enabled, use the passed-in thin-LTO cache as temp directory #9860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

akyrtzi
Copy link

@akyrtzi akyrtzi commented Jan 21, 2025

This ensures that we can move cached artifacts from the remote service to the temp directory because they should be on the same disk volume.

rdar://126211886

@akyrtzi
Copy link
Author

akyrtzi commented Jan 21, 2025

@swift-ci Please test LLVM

…in-LTO cache as temp directory

This ensures that we can move cached artifacts from the remote service to the temp directory because they
should be on the same disk volume.

rdar://126211886
@akyrtzi akyrtzi force-pushed the akyrtzi/pr/remote-thinlto-fix branch from 3f0740a to d6e0562 Compare January 21, 2025 23:33
@akyrtzi
Copy link
Author

akyrtzi commented Jan 21, 2025

@cachemeifyoucan I've made a change to avoid overriding SavedObjectsDirectoryPath if it is non-empty.

@akyrtzi
Copy link
Author

akyrtzi commented Jan 21, 2025

@swift-ci Please test LLVM

Copy link

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@akyrtzi akyrtzi merged commit a1670ab into swiftlang:next Jan 22, 2025
0 of 2 checks passed
@akyrtzi akyrtzi deleted the akyrtzi/pr/remote-thinlto-fix branch January 22, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants