Skip to content

[ThinLTO][Cache] When remote caching is enabled, use the passed-in thin-LTO cache as temp directory #9867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

akyrtzi
Copy link

@akyrtzi akyrtzi commented Jan 22, 2025

This ensures that we can move cached artifacts from the remote service to the temp directory because they should be on the same disk volume.

rdar://126211886
(cherry picked from commit d6e0562)

…in-LTO cache as temp directory

This ensures that we can move cached artifacts from the remote service to the temp directory because they
should be on the same disk volume.

rdar://126211886
(cherry picked from commit d6e0562)
@akyrtzi akyrtzi requested a review from a team as a code owner January 22, 2025 01:03
@akyrtzi
Copy link
Author

akyrtzi commented Jan 22, 2025

@swift-ci Please test

@akyrtzi
Copy link
Author

akyrtzi commented Jan 22, 2025

  • Explanation: Remote caching for thin-LTO is not working when dSYM generation is not enabled in the project and the remote service puts artifacts in different disk volume than the temp directory. Cache hits fail with a rename error and it falls back to CPU computation.
  • Scope: Only affects remote caching for thin-LTO.
  • Issue/Radar: rdar://126211886
  • Original PR: [ThinLTO][Cache] When remote caching is enabled, use the passed-in thin-LTO cache as temp directory #9860
  • Risk: Very low, only affects the code path using remote caching for thin-LTO.
  • Testing: Existing regression tests pass and manual testing with a test project.
  • Reviewer: @cachemeifyoucan

@fredriss fredriss merged commit a321a98 into swiftlang:swift/release/6.1 Jan 22, 2025
3 checks passed
@akyrtzi akyrtzi deleted the akyrtzi/pr/stable-remote-thinlto-fix branch January 22, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants