Add deprecated serverSideFiltering for backward compatibility #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzyzanowskim
changed the title
|
Can I get a review of this one please? |
ahoppen
reviewed
Jan 8, 2024
| @@ -18,6 +18,9 @@ public struct SKCompletionOptions: Codable, Hashable { | |||
| /// The maximum number of completion results to return, or `nil` for unlimited. | |||
| public var maxResults: Int? | |||
|
|
|||
| @available(*, deprecated, message: "Not used") | |||
There was a problem hiding this comment.
Could you add a the explanation of you PR’s description as a doc comment here?
ahoppen
approved these changes
Jan 8, 2024
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add deprecated serverSideFiltering parameter.
resoning: currently shipped sourcekit-lsp binaries reject request sent from client to server when the parameter is missing. By adding the parameter with default value true the client that uses LanguageServerProtocol as model can still interact with shipped sourcekit-lsp instances.