Skip to content

Add deprecated serverSideFiltering for backward compatibility #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ public struct SKCompletionOptions: Codable, Hashable {
/// The maximum number of completion results to return, or `nil` for unlimited.
public var maxResults: Int?

/// Older `sourcekit-lsp` binaries reject request sent from client to
/// server when the parameter is missing. By adding the parameter with default
/// value true the client that uses **LanguageServerProtocol** as model can still
/// interact with shipped `sourcekit-lsp` instances.
@available(*, deprecated, message: "Not used")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a the explanation of you PR’s description as a doc comment here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. done.

public private(set) var serverSideFiltering: Bool = true

public init(maxResults: Int? = 200) {
self.maxResults = maxResults
}
Expand Down