Produce an index log for the client #1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ets being prepared in the work done progress
This allows a user of SourceKit-LSP to inspect the result of background indexing. This allows a user of SourceKit-LSP to inspect the result of background indexing. I think this gives useful insights into what SourceKit-LSP is indexing and why/how it fails, if it fails, also for users of SourceKit-LSP. rdar://127474136 Fixes swiftlang#1265
|
@swift-ci Please test |
Comment on lines
+88
to
+91
| // We can get into a situation where queuedIndexTasks < indexTasks.count if we haven't processed all | ||
| // `indexTasksWereScheduled` calls yet but the semantic index managers already track them in their in-progress tasks. | ||
| // Clip the finished tasks to 0 because showing a negative number there looks stupid. | ||
| let finishedTasks = max(queuedIndexTasks - indexTasks.count, 0) |
There was a problem hiding this comment.
Just realized that queuedIndexTasks will be artificially high if you schedule a re-index for a file multiple times, right?
There was a problem hiding this comment.
Yes. It’s mitigated a little bit by the fact that we don’t increment the queuedIndexTasks from scheduleIndexing for files that we know are up-to-date.
And at least in the current design, I do want to increment the queuedIndexTasks for each file to index eg. in the following scenario
- Schedule indexing of A.swift and B.swift -> 0 / 2
- Indexing of A.swift finishes -> 1 / 2
- A.swift is modified and should be indexed again -> 1 / 3
- B.swift finishes indexing -> 2 / 3
- A.swift finishes indexing for the second time -> 3 / 3 -> Status disappears
The alternative would be to decrement the numerator when A.swift is modified but I think that’s confusing.
But it is worth guarding against the following scenario:
- Schedule indexing of A.swift and B.swift -> 0 / 2
- A.swift is modified and should be indexed again -> Should still be 0 / 2, currently would be not 1 / 3
- A.swift finishes indexing -> 1 / 2
- B.swift finishes indexing -> 2 / 2 -> Status disappears
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
May 22, 2024
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a user of SourceKit-LSP to inspect the result of background indexing. I think this gives useful insights into what SourceKit-LSP is indexing and why/how it fails, if it fails, also for users of SourceKit-LSP.
rdar://127474136
rdar://128071435
Fixes #1265
Fixes #1299