Merge main into release/6.0
#1341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…task hasn't been started yet and the document is no longer active When the user opens documents from three targets A, B, and C in quick succession, then we don’t want to schedule preparation of wait until A *and* B are finished preparing before preparing C. Instead, we want to - Finish for preparation of A to finish if it has already started by the time the file in C is opened. This is done so we always make progress during preparation and don’t get into a scenario where preparation is always cancelled if a user switches between two targets more quickly than it takes to prepare those targets. - Not prepare B because it is no longer relevant and we haven’t started any progress here. Essentially, we pretend that the hop to B never happened.
…-for-editor Cancel preparation tasks for editor functionality if the preparation task hasn't been started yet and the document is no longer active
Fix issue that caused topological order to be incorrect
…ets being prepared in the work done progress
This allows a user of SourceKit-LSP to inspect the result of background indexing. This allows a user of SourceKit-LSP to inspect the result of background indexing. I think this gives useful insights into what SourceKit-LSP is indexing and why/how it fails, if it fails, also for users of SourceKit-LSP. rdar://127474136 Fixes swiftlang#1265
This allows us to run `sourcekit-lsp index --project /path/to/project` to index a project. Intended to debugging purposes, eg. - Profile the time it takes to index a project - See if the project can be indexed successfully - Look at signposts generated during indexing in Instruments to see whether indexing or preparation is the bottleneck and how well we can parallelize tasks.
…-scheduler-test Fix a non-deterministic test failure of `testTaskSuspension`
Produce an index log for the client
Add a development subcommand to index a project
This allows nice visualization of the indexing progress in Instruments.
We were calling `TaskScheduler.schedule` inside a `Task` in `TaskSchedulerTests`. This means that Swift concurrency could re-order the execution of those tasks and thus change the order in which tasks were enqueued to the `TaskScheduler`. Caused by e295a4e#diff-6a451b3244d65ded9386e2816360b7b1debbe6a519e3795d2046c7dbefa7a7d7R351
… `WorkDoneProgress`
When the client replies with an error to the `CreateWorkDoneProgressRequest`, we shouldn’t be sending updates for it.
Fix a non-deterministic test failure in the task scheduler
…-creates-two-workdoneprogress Fix a race condition that caused `IndexProgressManager` to create two `WorkDoneProgress`
Add signposts for background preparation and indexing
…uest` Since `handleNextRequest` handling doesn’t have to be in the order that the request handlers were specified anymore, the naming was misleading.
…Dependency` We could get a `DiagnosticsRefreshRequest` before the modified target had been re-prepared.
Address review comments to swiftlang#1322 and swiftlang#1326
…ne-progress-creation Respect failed work done progress creation
rdar://128601797
Disable `testTasksWithElevatedPrioritiesGetExecutedFirst`
…oneProgress` We didn’t take into account that there are also work done progress notifications for package reloading. Only listen for
…-test-failure Fix a non-deterministic failure of `testBackgroundIndexingStatusWorkDoneProgress`
In SourceKit-LSP, we can get into the following situation: 1. We open A.swift 2. We issue a request for A.swift, the request takes a while to execute 3. The dependencies of A.swift are updated, which causes us to reopen the document in sourcekitd, so that the AST is rebuilt 4. This shouldn’t cause the request from (2) to be cancelled. We should continue executing it and only re-open the document after the request from (2) has finished rdar://127475366
…-request-on-close
|
@swift-ci Please test |
bnbarham
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the following PRs into
release/6.0:testTaskSuspension#1330IndexProgressManagerto create twoWorkDoneProgress#1333testTasksWithElevatedPrioritiesGetExecutedFirst#1337testBackgroundIndexingStatusWorkDoneProgress#1338