Skip to content

Replace an assertion by a fault log in WorkDoneProgressState #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 31, 2024

We didn’t hit this assertion but I noticed it and the best practice in sourcekit-lsp is to log a fault instead of throwing an assertion for any kind of recoverable error.

We didn’t hit this assertion but I noticed it and the best practice in sourcekit-lsp is to log a fault instead of throwing an assertion for any kind of recoverable error.
@ahoppen ahoppen requested a review from benlangmuir as a code owner May 31, 2024 07:07
@ahoppen ahoppen requested review from bnbarham and hamishknight May 31, 2024 07:07
@ahoppen
Copy link
Member Author

ahoppen commented May 31, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit c8e1eab into swiftlang:main May 31, 2024
3 checks passed
@ahoppen ahoppen deleted the fault-instead-of-assert-in-workdoneprogressstate branch May 31, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants