Skip to content

Replace an assertion by a fault log in WorkDoneProgressState #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024
Merged

Replace an assertion by a fault log in WorkDoneProgressState #1377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Sources/SourceKitLSP/WorkDoneProgressState.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
//
//===----------------------------------------------------------------------===//

import LSPLogging
import LanguageServerProtocol
import SKSupport

Expand Down Expand Up @@ -108,7 +109,10 @@ final actor WorkDoneProgressState {
}

func endProgressImpl(server: SourceKitLSPServer) async {
assert(activeTasks > 0, "Unbalanced startProgress/endProgress calls")
guard activeTasks > 0 else {
logger.fault("Unbalanced startProgress/endProgress calls")
return
}
activeTasks -= 1
guard await server.capabilityRegistry?.clientCapabilities.window?.workDoneProgress ?? false else {
return
Expand Down