Add notification to inform SourceKit-LSP about the currently active document #1989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
reviewed
Feb 19, 2025
| @@ -725,15 +727,16 @@ extension SourceKitLSPServer: QueueBasedMessageHandler { | |||
|
|
|||
| logger.log("Received request \(id): \(params.forLogging)") | |||
|
|
|||
| if let textDocumentRequest = params as? any TextDocumentRequest { | |||
| if self.capabilityRegistry?.clientHasExperimentalCapability(DidChangeActiveDocumentNotification.method) ?? false, | |||
There was a problem hiding this comment.
Shouldn't this be the reverse (ie. only infer the active document if the client doesn't support this notification)?
There was a problem hiding this comment.
Oh, whoops. That’s also why the tests are failing 😉
hamishknight
approved these changes
Feb 19, 2025
ahoppen
force-pushed
the
didchangactivedocument
branch
from
3875111 to
2a2e1fe
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
…ocument SourceKit-LSP prepares the currently active file for editor functionality and currently infers the currently active document from whichever received the last `TextDocumentRequest`. If an editor is capable of doing so, it should be able to report the document that the user currently has focused so that SourceKit-LSP does not have to infer this information from other requests. Also clean up some handling code for experimental capabilities.
ahoppen
force-pushed
the
didchangactivedocument
branch
from
2a2e1fe to
4d00c90
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Feb 24, 2025
`sourcekit-lsp` recently added an LSP extension method to notify the server of the active documnent, so it doesn't need to infer it from information in other requests. This capability was added in swiftlang/sourcekit-lsp#1989.
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Feb 24, 2025
`sourcekit-lsp` recently added an LSP extension method to notify the server of the active documnent, so it doesn't need to infer it from information in other requests. This capability was added in swiftlang/sourcekit-lsp#1989.
plemarquand
added a commit
to swiftlang/vscode-swift
that referenced
this pull request
Mar 17, 2025
`sourcekit-lsp` recently added an LSP extension method to notify the server of the active documnent, so it doesn't need to infer it from information in other requests. This capability was added in swiftlang/sourcekit-lsp#1989. Co-authored-by: Alex Hoppen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceKit-LSP prepares the currently active file for editor functionality and currently infers the currently active document from whichever received the last
TextDocumentRequest.If an editor is capable of doing so, it should be able to report the document that the user currently has focused so that SourceKit-LSP does not have to infer this information from other requests.
Also clean up some handling code for experimental capabilities.