Notify sourcekit-lsp of active document changes #1404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
|
@ahoppen This makes the assumption its OK to notify about any file type, not just ones recognized by SourceKit-LSP. Is this correct? |
award999
reviewed
Feb 24, 2025
`sourcekit-lsp` recently added an LSP extension method to notify the server of the active documnent, so it doesn't need to infer it from information in other requests. This capability was added in swiftlang/sourcekit-lsp#1989.
plemarquand
force-pushed
the
lsp-change-active-document
branch
from
20bc378 to
ad20f13
Compare
|
Good points, Paul. I am clarifying the spec to answer these questions in swiftlang/sourcekit-lsp#1994. |
Co-authored-by: Alex Hoppen <[email protected]>
rbenegal
approved these changes
Mar 17, 2025
matthewbastien
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourcekit-lsprecently added an LSP extension method to notify the server of the active documnent, so it doesn't need to infer it from information in other requests. This capability was added in swiftlang/sourcekit-lsp#1989.This also relies on swiftlang/sourcekit-lsp#1994