Use SourceKit's not_recommended field to populate deprecated in Code Completion responses #203
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this really depend on the textedit change, or it just happens to include it? The not_recommended -> deprecated part of this LGTM. |
|
It just causes merge conflicts since the two changes are too close together. So I decided it’s easier to just merge one after the other. |
ahoppen
force-pushed
the
not-recommended-to-deprecated
branch
from
437d059 to
949c1e1
Compare
|
@swift-ci Please test |
benlangmuir
approved these changes
Dec 10, 2019
…completion responses
ahoppen
force-pushed
the
not-recommended-to-deprecated
branch
from
949c1e1 to
acd8843
Compare
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
not_recommendedflag in SourceKit to some degree matches thedeprecatedfield in LSP. Instead of not providing any deprecation information, it might be a good idea to map the fields, even if they don't match exactly.