[linux] Re-enable parallel testing after avoiding static destructors #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After updating libsourcekitdInProc to stop exporting all of the llvm symbols, we can now safely load it without RTLD_DEEPBIND. This notably fixes running with asan on Linux.
To prevent crashes during `exit` caused by SR-12668, avoid running static destructors. During testing, we do this by interposing `__cxa_exit` to prevent registration of destructors. This depends on the previous commit that disabled RTLD_DEEPBIND. In the sourcekit-lsp executable, since we control the exit points, we can make a less invasive change to just use `_Exit` instead of `exit` to avoid cleanups. This should hopefully fix the CI issues we have seen when testing with --parallel. rdar://61837752
rdar://61837752
|
swiftlang/swift#31287 |
|
swiftlang/swift#31287 |
|
Locally tested by running tests with |
|
swiftlang/swift#31287 |
|
@swift-ci please test |
Seems to be the newer version.
benlangmuir
force-pushed
the
parallelize-but-not-destructorize
branch
from
5bffd44 to
4c925df
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid the crash that has been affecting parallel testing on Ubuntu 16.04.