-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[sourcekitd] Use add_llvm_symbol_exports instead of our old copy #31287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sourcekitd] Use add_llvm_symbol_exports instead of our old copy #31287
Conversation
Reduces duplication with llvm and, more importantly, gives us Linux support via a linker script. This will let us link libsourcekitdInProc in binaries that have their own copy of llvm symbols on Linux, and let sourcekit-lsp stop using dlopen with `RTLD_DEEPBIND`, which fixes running with asan among other things.
@swift-ci please test |
@swift-ci please build toolchain |
Build failed |
Linux Toolchain (Ubuntu 16.04) Install command |
@swift-ci please build toolchain macOS |
@swift-ci please test macOS |
Build failed |
The macOS failure is due to an incorrect automerge in lldb fixed by @fredriss on Friday.
Lets give this another shot. |
@swift-ci please test macOS platform |
@swift-ci please build toolchain macOS |
macOS Toolchain Install command |
Reduces duplication with llvm and, more importantly, gives us Linux
support via a linker script. This will let us link libsourcekitdInProc
in binaries that have their own copy of llvm symbols on Linux, and let
sourcekit-lsp stop using dlopen with
RTLD_DEEPBIND
, which fixesrunning with asan among other things.