Fix the Pipe handling on Windows to be correct #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test |
benlangmuir
reviewed
Oct 29, 2020
|
@swift-ci please test |
benlangmuir
approved these changes
Oct 30, 2020
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
benlangmuir
suggested changes
Nov 2, 2020
This actually addresses the real issue that was ignored earlier about pipes on Windows. The FileHandle cannot provide a non-owning file descriptor (the returned file descriptor would need to be explicitly `_close`'d by the receiver). Foundation now vends a `_handle` accessor to the OS primitive handle. Use this to create the dispatch loop for messaging. We now create the JSONRPCConnection from handles on Windows which actually should help enable running some of the tests on Windows as well.
|
@swift-ci please test |
benlangmuir
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually addresses the real issue that was ignored earlier about
pipes on Windows. The FileHandle cannot provide a non-owning file
descriptor (the returned file descriptor would need to be explicitly
_close'd by the receiver). Foundation now vends a_handleaccessorto the OS primitive handle. Use this to create the dispatch loop for
messaging. We now create the JSONRPCConnection from handles on Windows
which actually should help enable running some of the tests on Windows
as well.