Workaround SR-13822 by keeping the file handle alive for the connection #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, the file handle is closing the file descriptor on deinit despite `closeOnDealloc: false` (https://bugs.swift.org/browse/SR-13822). Workaround by keping the FileHandle alive. rdar://70995458
|
@swift-ci please test |
|
@compnerd FYI we saw failures in a sourcekit-lsp integration test on Linux (and the same issue would presumably affect Windows) after #341: The problem seems to be that corelibs-foundation FileHandle is always closing the file, even with |
|
@benlangmuir thanks for the heads up! Sorry about this :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, the file handle is closing the file descriptor on deinit
despite
closeOnDealloc: false(https://bugs.swift.org/browse/SR-13822). Workaround by keping the
FileHandle alive.
rdar://70995458