[Dependency Scanner] Add missing clang overlay dependencies for placeholder modules #34545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
nkcsgexi
approved these changes
Nov 2, 2020
…holder modules We were previously forgetting about these. On top of that, make sure we treat accumulated dependencies as a set, because adding clang overlay dependencies may duplicate existing already-added dependencies for some module.
artemcm
force-pushed
the
FixPlaceholderOverlayDeps
branch
from
d2e2be2 to
de80717
Compare
|
@swift-ci please smoke test |
|
Hit a test failure for test-sourcekit-lsp/test-sourcekit-lsp.py to be fixed by swiftlang/sourcekit-lsp#343. |
|
@swift-ci please smoke test Linux platform |
artemcm
added a commit
that referenced
this pull request
Nov 5, 2020
Revert the Revert of #34545: [Dependency Scanner] Add missing clang overlay dependencies for placeholder modules
ainu-bot
added a commit
to google/swift
that referenced
this pull request
Nov 5, 2020
* 'main' of github.com:apple/swift: Revert the Revert of swiftlang#34545: [Dependency Scanner] Add missing clang overlay dependencies for placeholder modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously forgetting about these.
On top of that, make sure we treat accumulated dependencies as a set, because adding clang overlay dependencies may duplicate existing already-added dependencies for some module.