Skip to content

Revert the Revert of #34545: [Dependency Scanner] Add missing clang overlay dependencies for placeholder modules #34575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Nov 4, 2020

With the added test fixed to be more generic to platforms.

@artemcm
Copy link
Contributor Author

artemcm commented Nov 4, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 4, 2020

Build failed
Swift Test OS X Platform
Git Sha - 4260808eb6dc441975db76f5feb18c9fd773c657

…g clang overlay dependencies for placeholder modules

With the added test fixed to be more generic to platforms.

This reverts commit 0f00ea1, reversing
changes made to 0092608.
@artemcm artemcm force-pushed the RevertRevertClangOverlayDeps branch from 4260808 to d5f13c4 Compare November 4, 2020 22:08
@artemcm
Copy link
Contributor Author

artemcm commented Nov 4, 2020

@swift-ci please test

@artemcm artemcm merged commit 937fee4 into swiftlang:main Nov 5, 2020
@artemcm artemcm deleted the RevertRevertClangOverlayDeps branch November 5, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants