Dynamically register completion options for supporting clients #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using dynamic registration (when supported by the client) allows us to provide different completion options for ObjC and Swift files. We should be able to expand this to other capabilities in the future (e.g. semantic highlighting, execute command support).
|
@swift-ci please test |
benlangmuir
reviewed
Mar 22, 2021
Sources/LanguageServerProtocol/SupportTypes/RegistrationOptions.swift
Outdated
Show resolved
Hide resolved
| registry: CapabilityRegistry | ||
| ) { | ||
| guard let completionOptions = server.completionProvider else { return } | ||
| guard registry.completionSupported && !registry.hasCompletionRegistrations(for: languages) else { return } |
There was a problem hiding this comment.
Why does it bail out if there are already registrations? I would have expected we'd check if they're equal.
There was a problem hiding this comment.
If we have a conflicting registration for completion there's not much we can do unless we try to manually merge them - I guess I could just log it if that happens?
There was a problem hiding this comment.
Yeah, how about we log a warning here unless the options are identical to what's already registered for that language.
|
@swift-ci please test |
benlangmuir
reviewed
Apr 5, 2021
Sources/LanguageServerProtocol/SupportTypes/RegistrationOptions.swift
Outdated
Show resolved
Hide resolved
Sources/LanguageServerProtocol/SupportTypes/RegistrationOptions.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci please test |
|
@swift-ci please test |
benlangmuir
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using dynamic registration (when supported by the client) allows
us to provide different completion options for ObjC and Swift
files.
We should be able to expand this to other capabilities in the future
(e.g. semantic highlighting, execute command support).