Skip to content

Add support for clangd's semantic highlighting #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 12, 2021
Merged

Add support for clangd's semantic highlighting #388

merged 5 commits into from
Apr 12, 2021

Conversation

DavidGoldman
Copy link
Contributor

  • Add LSP types for semantic highlighting
  • Limited to clients which support dynamic registration for semantic
    highlighting
  • Requires clangd 11 or later

@DavidGoldman
Add support for clangd's semantic highlighting
63ef2c1 
- Limited to clients which support dynamic registration for semantic
  highlighting
- Requires clangd 11 or later
@DavidGoldman
Copy link
Contributor Author

@swift-ci please test

@DavidGoldman
Copy link
Contributor Author

Before:
No semantic highlighting

After:
With semantic highlighting

@DavidGoldman DavidGoldman mentioned this pull request Apr 8, 2021
Closed
@DavidGoldman
Copy link
Contributor Author

Also added a warning for the PR comment that I missed on #380

@akyrtzi
Copy link
Contributor

akyrtzi commented Apr 8, 2021

Awesome! 🥳

@DavidGoldman
Copy link
Contributor Author

@swift-ci please test

benlangmuir
benlangmuir reviewed Apr 12, 2021
View reviewed changes
@DavidGoldman
Copy link
Contributor Author

@swift-ci please test

@DavidGoldman DavidGoldman merged commit ad9b09e into swiftlang:main Apr 12, 2021
@mackoj mackoj mentioned this pull request Apr 16, 2021
Closed
@fwcd fwcd mentioned this pull request Jul 3, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlangmuir benlangmuir benlangmuir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidGoldman @akyrtzi @benlangmuir