On ELF platforms, remove the host toolchain rpath from sourcekit-lsp before installing #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…before installing.
|
To clarify: after this change is the runpath |
|
@swift-ci please test |
|
Yep, just those two relative rpaths after. |
|
Thx, I'll submit for the 5.5 branch too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this pull, I see this in the latest official trunk snapshot build:
I've been removing these host
/home/build-user/CI paths from the linux toolchain component by component, eg swiftlang/swift-package-manager#2703, this is the last remaining piece. No need to check if it's non-Darwin as in that SPM pull, as this flag does nothing on macOS.