Skip to content

[5.5] On ELF platforms, remove the host toolchain rpath from sourcekit-lsp before installing #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2021
Merged

[5.5] On ELF platforms, remove the host toolchain rpath from sourcekit-lsp before installing #418

merged 1 commit into from
Jul 20, 2021

Conversation

finagolfin
Copy link
Member

Cherry-pick of #417

  • Explanation: This removes the build toolchain's rpath for the shipping sourcekit-lsp executable on ELF platforms.
  • Scope: Only removes an extraneous rpath from the sourcekit-lsp executable
  • Risk: None
  • Testing: This unused host CI rpath has been removed for all other shipping executables and libraries without a problem.
  • Reviewer: @benlangmuir

@finagolfin finagolfin requested a review from benlangmuir as a code owner July 20, 2021 08:12
@akyrtzi
Copy link
Contributor

akyrtzi commented Jul 20, 2021

@swift-ci Please test

@benlangmuir
Copy link
Contributor

@swift-ci Please test macOS

@akyrtzi akyrtzi merged commit 1abe633 into swiftlang:release/5.5 Jul 20, 2021
@finagolfin finagolfin deleted the 5.5 branch July 21, 2021 08:14
@finagolfin
Copy link
Member Author

Thanks for the quick turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akyrtzi akyrtzi akyrtzi approved these changes

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@finagolfin @akyrtzi @benlangmuir