begin to integrate SwiftSystem #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: SwiftSystem provides infra that can replace some bespoke implementations in TSC and, improving the cross-platform support. as such we are adding it as a dependency to TSC changes: add SwiftSystem to CMake setup so it can be included in CMake based builds
|
cc @compnerd |
|
cc @compnerd |
|
Is there a reason to add this to the cmake but not the Package.swift? The change itself seems fine. |
benlangmuir
approved these changes
Nov 20, 2021
|
swiftpm will bring it transitively: lsp -> swiftpm -> tsc -> system, so no needed to add explicitly this change is only required for the cmake build of lsp to continue and work once the change lands in tsc/swiftpm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: SwiftSystem provides infra that can replace some bespoke implementations in TSC and, improving the cross-platform support. as such we are adding it as a dependency to TSC
changes: add SwiftSystem to CMake setup so it can be included in CMake based builds