begin to integrate SwiftSystem #3881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: SwiftSystem provides infra that can replace some bespoke implmentations in TSC and SwiftPM, improving the cross-platform support changes: add SwiftPM and CMake setup for including SwiftSystem as a dependency
|
cc @compnerd |
abertelrud
approved these changes
Nov 20, 2021
compnerd
requested changes
Nov 21, 2021
There was a problem hiding this comment.
This needs accompanying changes to swift-installer-scripts to package up the new dependencies into the installer. I'll need to adjust the Windows builds on Azure accordingly for the nightlies, and we should also update the scripts in apple/swift at utils/build-windows-toolchain.bat (this is in preparation for migrating the windows release/nightlies to swift.org, and is actually currently in use at https://ci-external.swift.org/job/oss-swift-windows-toolchain-x86_64-vs2019/)
compnerd
approved these changes
Dec 6, 2021
neonichu
approved these changes
Dec 6, 2021
tomerd
added
the
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: SwiftSystem provides infra that can replace some bespoke implementations in TSC and SwiftPM, improving the cross-platform support
changes: add SwiftPM and CMake setup for including SwiftSystem as a dependency