Upgrade Swift Argument Parser to version 1.1.2 #555
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2022
ahoppen
previously approved these changes
May 23, 2022
There was a problem hiding this comment.
LGTM, assuming the issues in swiftlang/swift-driver#1106 are resolved.
ahoppen
dismissed
their stale review
Waiting until issues mentioned in swiftlang/swift-driver#1106 are resolved.
|
rdar://99561854 |
|
Closing as superseded by #673 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the Swift Argument Parser dependency to version 1.1.2. This is the latest version of the dependency and supports new features like async/await via the
AsyncParsableCommandtype.In order to upgrade this dependency, it must also be upgraded in swift-package-manager and swift-driver.
I believe the correct order to merge these PRs would be: