Skip to content

build: repair the build after the TSCUtility changes #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Jan 4, 2023

SKSupport now requires a link against Foundation, update the build system to track that dependency.

SKSupport now requires a link against Foundation, update the build
system to track that dependency.
@compnerd
Copy link
Member Author

compnerd commented Jan 4, 2023

@swift-ci please test

@MaxDesiatov
Copy link
Contributor

MaxDesiatov commented Jan 4, 2023

Build in the swift repo still fails, but now instead of missing Foundation the error looks like this:

SKSupport\ByteString.swift:15:15: error: no such module 'TSCBasic'

import struct TSCBasic.ByteString

@MaxDesiatov
Copy link
Contributor

@compnerd I hope you don't mind the additional commit from me to your branch as an attempt to fix this sooner

@MaxDesiatov
Copy link
Contributor

@swift-ci test

@compnerd
Copy link
Member Author

compnerd commented Jan 4, 2023

@MaxDesiatov that will teach me to create PRs without a local test 🤦‍♂️

@MaxDesiatov
Copy link
Contributor

@swift-ci test

@compnerd
Copy link
Member Author

compnerd commented Jan 4, 2023

@swift-ci please test macOS platform

@compnerd compnerd merged commit b55057a into swiftlang:main Jan 5, 2023
@compnerd compnerd deleted the build branch January 5, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants