Skip to content

PrebuiltModuleGen: Print an error instead of crashing when SWIFT_EXEC is invalid #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2023
Merged

PrebuiltModuleGen: Print an error instead of crashing when SWIFT_EXEC is invalid #1246

merged 1 commit into from
Jan 4, 2023

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Jan 3, 2023

Now users will see a diagnostic like this:

error: value of SWIFT_EXEC is not a valid absolute path: ../build/Ninja-RelWithDebInfoAssert/swift-macosx-arm64/bin/swiftc

Also, fix a diagnostic typo.

@tshortli tshortli requested a review from nkcsgexi January 3, 2023 19:15
@tshortli
Copy link
Contributor Author

tshortli commented Jan 3, 2023

@swift-ci please test

@tshortli
Copy link
Contributor Author

tshortli commented Jan 4, 2023

@swift-ci please test Windows

@tshortli
Copy link
Contributor Author

tshortli commented Jan 4, 2023

swiftlang/sourcekit-lsp#689

@swift-ci please test Windows

@tshortli tshortli merged commit 689c608 into swiftlang:main Jan 4, 2023
@tshortli tshortli deleted the swift-exec-absolute-path branch January 4, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

@artemcm artemcm artemcm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tshortli @nkcsgexi @artemcm