Only log build settings once unless they change #932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the logs a lot less spammy.
|
@swift-ci Please test |
bnbarham
reviewed
Oct 27, 2023
| fileprivate actor BuildSettingsLogger { | ||
| static let shared = BuildSettingsLogger() | ||
|
|
||
| private var loggedSettings: [DocumentURI: FileBuildSettings] = [:] |
There was a problem hiding this comment.
I know we likely already keep a document -> settings in memory for all the workspaces, but it would be nice to not (potentially) double it. Are you worried about some race if this was removed on close?
There was a problem hiding this comment.
AFAIK we don’t keep that mapping around anywhere. We used to but I removed the caches in SwiftLanguageServer and ClangLanguageServer.
SwiftPMWorkspace, for example, gets the build settings from the build graph and doesn’t have any file -> build settings cache.
There was a problem hiding this comment.
I’m merging this now. If you think this should be implemented otherwise, I can address it in a follow-up PR.
hamishknight
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the logs a lot less spammy.