Make DocumentManager.latestSnapshot throw if no snapshot exists for the URI
#943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
… the URI This simplifies most calls that would log an error + return an empty response if no document was found.
ahoppen
force-pushed
the
ahoppen/latest-snapshot-throw
branch
from
b320e7b to
96e0e48
Compare
|
@swift-ci Please test |
hamishknight
approved these changes
Oct 27, 2023
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies most calls that would log an error + return an empty response if no document was found.