Skip to content

Periodic merge main -> release 6.2 #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Apr 24, 2025
Merged

Periodic merge main -> release 6.2 #404

merged 46 commits into from
Apr 24, 2025

Conversation

owenv
Copy link
Collaborator

@owenv owenv commented Apr 11, 2025

No description provided.

jakepetroules and others added 21 commits April 3, 2025 23:28
This moves some Windows and macOS specific code out of core.
…s in test targets which exclusively use Swift Testing and enable LD_WARN_UNUSED_DYLIBS (#379)

Fixes rdar://148694760
Eliminate the package dependency on swift-crypto to simplify the bootstrapped build. Instead, vendor
the SHA256 implementation from swift-tools-support-core and use it as a fallback if neither WinSDK nor
CryptoKit is available.
This should hopefully give us more insight into flaky tests.
…requests

Noticed this; fix it before it bites someone later...
Make them work on Linux, and standardize how they're skipped if SDKs are not installed.

rdar://148676808
This removes support for compiling files with bitcode from SWBuild, as this functionality is no longer supported. This removes a lot of functionally dead code.

Support for stripping bitcode from copied files remains, as there are extant libraries and XCFrameworks which contain bitcode, which must be stripped. Bitcode was only supported for a subset of platforms, to the assignment of STRIP_BITCODE_FROM_COPIED_FILES in Settings based on platform remains, so time isn't spent stripping nonexistent bitcode from other platforms.

Some interfaces which Xcode uses continue to refer to bitcode for compatibility, but effectively do nothing.

Note that the references to bitcode in the OpenCL support are a concept internal to that tool, and independent of the support being removed here.

rdar://148287993
…uild description cache in tests

If we've told the build description manager to never evict build descriptions from its cache, ensure that the cache isn't attached to the heavy cache global state, so that it isn't cleared by other tests running concurrently.
Explicit module arguments are removed for the arguments returned for
indexing. Also disable them for preparation in general so we're not
mixing between the two.

Resolves rdar://147354913.
@owenv
Copy link
Collaborator Author

owenv commented Apr 11, 2025

@swift-ci test

Use our FSProxy abstraction instead of Foundation, which doesn't suffer from swiftlang/swift-foundation#860
@owenv
Copy link
Collaborator Author

owenv commented Apr 15, 2025

@swift-ci test linux

owenv and others added 10 commits April 16, 2025 20:56
…to combine all hits/misses

Separating by compiler is not that useful, this is intended for a high-level overview.
A couple of changes
* Report the combined cache hits/misses
* Report the summary as a diagnostic note to make it more visible
Noticed this during a bit of investigation into #21, and don't necessarily expect this to fix it, but it seems correct in order to prevent the fd possibly being closed while the stream is still being read.
Remarks pollute the issue navigator in Xcode, the notes are more appropriate as offering additional details for a particular task.
…all the compiler-specific caching settings

Also make the new setting, along with `COMPILATION_CACHE_ENABLE_DIAGNOSTIC_REMARKS` show up in settings UI.
Have its string representation print the actual error message for improved debuggability.
This goes in the task's output, so in the Xcode build log the user would have to expand the task output to see such detail.
@owenv
Copy link
Collaborator Author

owenv commented Apr 23, 2025

@swift-ci test

Audited the codebase for suspicious calls and improved the error handling.
Use the same technique being proposed in SwiftSystem and partly-implemented in Foundation.

As a follow-on change, we also need to stop using POSIX filesystem APIs, which are not Unicode or long path aware.
@owenv
Copy link
Collaborator Author

owenv commented Apr 23, 2025

@swift-ci test linux

@owenv
Copy link
Collaborator Author

owenv commented Apr 24, 2025

@swift-ci test linux

@owenv owenv force-pushed the owenv/update-6.2 branch from 6a60f3f to 09d78a5 Compare April 24, 2025 00:28
@owenv
Copy link
Collaborator Author

owenv commented Apr 24, 2025

@swift-ci test

@owenv owenv merged commit 0118c59 into release/6.2 Apr 24, 2025
1 check passed
@owenv owenv deleted the owenv/update-6.2 branch April 24, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.