Skip to content

Adopt new XCTAssertEqualWithAccuracy spelling in the tests. #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2017
Merged

Adopt new XCTAssertEqualWithAccuracy spelling in the tests. #1046

merged 1 commit into from
Jun 23, 2017

Conversation

briancroom
Copy link
Contributor

Once swiftlang/swift-corelibs-xctest#193 lands, this can go in to clean up the deprecation warnings.

@briancroom briancroom self-assigned this Jun 17, 2017
@parkera
Copy link
Contributor

parkera commented Jun 19, 2017

Looks ok to me

@alblue
Copy link
Contributor

alblue commented Jun 21, 2017

@swift-ci please test

@alblue
Copy link
Contributor

alblue commented Jun 21, 2017

Looks like it's failed with the missing 'accuracy:' arguments

TestFoundation/TestNSURLSession.swift -o ../Ninja-ReleaseAssert/foundation-linux-x86_64/TestFoundation/TestFoundation
TestFoundation/TestNSTimer.swift:62:13: error: argument labels '(_:, _:, accuracy:)' do not match any available overloads
            XCTAssertEqual(currentInterval, previousInterval + interval, accuracy: 0.01)
            ^

@alblue
Copy link
Contributor

alblue commented Jun 21, 2017

Ah, swiftlang/swift-corelibs-xctest#193 hasn't been merged yet :)

@briancroom
Copy link
Contributor Author

@swift-ci please test

@briancroom briancroom merged commit 320a63d into swiftlang:master Jun 23, 2017
@briancroom briancroom deleted the update-XCTAssertEqualWithAccuracy branch June 23, 2017 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briancroom briancroom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briancroom @parkera @alblue