[SR-5247] Add the new spellings for the *WithAccuracy assertion functions #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions This is to bring Corelibs XCTest in line with changes made in the main XCTest Swift overlay for Xcode 9. XCTAssertEqualWithAccuracy and XCTAssertNotEqualWithAccuracy are now deprecated in favor of XCTAssertEqual(_:_:accuracy:file:line:) and XCTAssertNotEqual(_:_:accuracy:file:line:) This fixes an inconsistency where XCTAssertEqualWithAccuracy had accuracy: as a named parameter, but XCTAssertNotEqualWithAccuracy had it unnamed.
|
@swift-ci please test |
modocache
approved these changes
Jun 17, 2017
|
The OSX build failed with: I'm not sure if this is to do with the updated version of Swift used on the build server - I'll try kicking it off again. @swift-ci please test macOS |
|
@swift-ci please test macOS |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Alright, it passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to bring Corelibs XCTest in line with changes made in the main XCTest Swift overlay for Xcode 9 (see here).
XCTAssertEqualWithAccuracyandXCTAssertNotEqualWithAccuracyare now deprecated in favor ofXCTAssertEqual(_:_:accuracy:file:line:)andXCTAssertNotEqual(_:_:accuracy:file:line:).This fixes an inconsistency where
XCTAssertEqualWithAccuracyhadaccuracy:as a named parameter, butXCTAssertNotEqualWithAccuracyhad it unnamed.