Fix warning: overlapping access to 'self' #1337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Overlapping accesses to 'self', but modification requires exclusive access; consider copying to a local variable
spevans
reviewed
Nov 27, 2017
Foundation/NSCalendar.swift
Outdated
| @@ -583,8 +583,9 @@ open class NSCalendar : NSObject, NSCopying, NSSecureCoding { | |||
| var at: CFAbsoluteTime = date.timeIntervalSinceReferenceDate | |||
|
|
|||
| let res: Bool = withUnsafeMutablePointer(to: &at) { t in | |||
| let copy = vector | |||
| return vector.withUnsafeMutableBufferPointer { (vectorBuffer: inout UnsafeMutableBufferPointer<Int32>) in | |||
There was a problem hiding this comment.
Would let count = Int32(vector.count) be better to reduce the size of the copy?
spevans
reviewed
Nov 27, 2017
TestFoundation/TestNSData.swift
Outdated
| mutatingHello.withUnsafeMutableBytes { (bytes : UnsafeMutablePointer<UInt8>) in | ||
| XCTAssertEqual(bytes.pointee, 0x68, "First byte should be 0x68") | ||
|
|
||
| // Mutate it | ||
| bytes.pointee = 0x67 | ||
| XCTAssertEqual(bytes.pointee, 0x67, "First byte should be 0x67") | ||
| XCTAssertEqual(mutatingHello[0], 0x67, "First byte accessed via other method should still be 0x67") | ||
| XCTAssertEqual(copy[0], 0x67, "First byte accessed via other method should still be 0x67") | ||
|
|
There was a problem hiding this comment.
Isn't this copy making the test redundant?
Would moving the XCTAssertEqual(mutatingHello[0] ... outside of the closure give the same effect?
|
@swift-ci please test |
|
Those fixes look good. |
|
@swift-ci please test and merge |
devincoughlin
added a commit
to devincoughlin/swift-corelibs-foundation
that referenced
this pull request
Apr 13, 2018
Fix an exclusivity warning in TestNSData by moving assertions outside outside of a withUnsafeMutableByte() closure. This mirrors the approach taken by swiftlang#1337 to avoid the analogous warning in a similar test in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are more of these in the codebase, but here's a fix for a few.