Skip to content

[Tests] Fix exclusivity warning in TestNSData #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devincoughlin
Copy link
Contributor

Fix an exclusivity warning in TestNSData by moving assertions outside
outside of a withUnsafeMutableByte() closure. This mirrors the approach
taken by #1337
to avoid the analogous warning in a similar test in this file.

Fix an exclusivity warning in TestNSData by moving assertions outside
outside of a withUnsafeMutableByte() closure. This mirrors the approach
taken by swiftlang#1337
to avoid the analogous warning in a similar test in this file.
@devincoughlin
Copy link
Contributor Author

@phausler Would you be willing to take a look? This is a similar fix to what @ianpartridge did in #1337

@devincoughlin
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@parkera parkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take this one. LGTM

@devincoughlin devincoughlin merged commit 90acdc7 into swiftlang:master Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants