[gardening][Measurement] Move operators into types #1349
Conversation
|
@swift-ci Please test |
| let lhsValueInTermsOfBase = lhs.unit.converter.baseUnitValue(fromValue: lhs.value) | ||
| let rhsValueInTermsOfBase = rhs.unit.converter.baseUnitValue(fromValue: rhs.value) | ||
| return Measurement(value: lhsValueInTermsOfBase - rhsValueInTermsOfBase, unit: type(of: lhs.unit).baseUnit()) | ||
| extension Measurement where UnitType : Dimension { |
There was a problem hiding this comment.
I'm not sure that having a lot of new extensions is ideal. Could we move this inside the existing extension on line 47?
There was a problem hiding this comment.
Every single method seems to be in its own extension although some are using a conditional conformance so this is consistent. However maybe a followup PR could merge them so there are only two extensions.
There was a problem hiding this comment.
Every single method seems to be in its own extension although some are using a conditional conformance so this is consistent. However maybe a followup PR could merge them so there are only two extensions.
Yep I'm going to do that.
There was a problem hiding this comment.
OK as long as this PR isn't the end then 👍
|
@swift-ci please test and merge |
|
Thanks @ianpartridge and @spevans! |
|
I believe this code is also shared with the overlay. |
https://github.com/apple/swift-corelibs-foundation/pull/1349/files?w=1