Synchronize Measurement.swift from the overlay #1353
Merged
+117
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
parkera
reviewed
Dec 4, 2017
|
|
||
| extension MeasurementFormatter { | ||
| public func string<UnitType>(from measurement: Measurement<UnitType>) -> String { NSUnimplemented() } | ||
| } |
There was a problem hiding this comment.
Why did this function go away?
There was a problem hiding this comment.
Since that is implemented here: https://github.com/apple/swift-corelibs-foundation/pull/1353/files#diff-4454b507f83169b4745628b0daeb7207R257
There was a problem hiding this comment.
Totally missed that. Thanks, this looks great.
parkera
approved these changes
Dec 4, 2017
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subsequent PR of #1349 and #1350.
This contains the changes from swiftlang/swift#4167.