skip this test until string guts are in our submission branch #1445
Conversation
|
@swift-ci please test |
|
cc @parkera |
TestFoundation/TestNSString.swift
Outdated
| @@ -1211,22 +1211,41 @@ class TestNSString : XCTestCase { | |||
| } | |||
|
|
|||
| struct ComparisonTest { | |||
| enum TestBehavior { | |||
| case run | |||
| case xfail(String) | |||
There was a problem hiding this comment.
xfail may be used in other places but is not very readable imho. Can we expand this to perhaps expectedFailure or something more indicative of what it is meant to be used for?
| @@ -1385,6 +1405,10 @@ func checkHasPrefixHasSuffix(_ lhs: String, _ rhs: String, _ stack: [UInt]) -> I | |||
| extension TestNSString { | |||
| func test_PrefixSuffix() { | |||
| for test in comparisonTests { | |||
| if case .skip = test.behavior { | |||
There was a problem hiding this comment.
the PR is claiming a skip of a single test but that seems rather contrary to the additions and refactoring of reasons to xfail etc. Can we split this up into two parts?
There was a problem hiding this comment.
Normally, I'd be fine with that but we're trying to unblock testing and I don't think it's worth while to have 2 PRs for such a small change. I can split it up if you insist but I'd rather just unblock CI.
|
@swift-ci please test |
|
(trying again because it looks like the timeouts are at least partially resolved) @swift-ci please test |
|
@swift-ci please clean test |
1 similar comment
|
@swift-ci please clean test |
|
@swift-ci please clean test |
1 similar comment
|
@swift-ci please clean test |
|
@swift-ci please test |
|
@lancep "clean" is not supported with this repo. |
|
We really need to unblock this. Can we get a manager's permission to force-merge? |
|
Mishal bumped the timeout, let's see if it passes this time @swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test and merge |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
No description provided.