ClangImporter: Update Swift for changes in clang (PCH + Modules issues) #14765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the NeededByPCHOrCompilationUsesPCH language option when emitting a brigding PCH. rdar://problem/35056912 rdar://problem/30384801 Initial patch by Adrian Prantl
|
Please test with following PR: @swift-ci Please test |
|
Build failed |
jrose-apple
approved these changes
Feb 21, 2018
|
Ah, Linux testing on the 5.0 branch is currently broken due to swiftlang/swift-corelibs-foundation#1445. |
|
Build failed |
|
Please test with following PR: @swift-ci Please test |
|
Build failed |
|
Build failed |
|
Seems like the problem hasn't gone yet =T |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the NeededByPCHOrCompilationUsesPCH language option when
emitting a brigding PCH.
rdar://problem/35056912
rdar://problem/30384801
Initial patch by Adrian Prantl