Added modern URL API to Foundation.Process #1461
Conversation
pvieito
commented
Mar 4, 2018
pvieito
commented
- Deprecated old path API as Darwin Foundation
- Deprecated old path API as Darwin Foundation
|
@swift-ci please test |
| @@ -164,13 +164,40 @@ open class Process: NSObject { | |||
|
|
|||
| } | |||
|
|
|||
| @available(*, deprecated) | |||
There was a problem hiding this comment.
These are actually not marked as deprecated yet in the SDK.
There was a problem hiding this comment.
The new implementation looks reasonable but we can leave the deprecation annotation off for now.
There was a problem hiding this comment.
It is marked as deprecated in the documentation: https://developer.apple.com/documentation/foundation/process/1413110-currentdirectorypath
Maybe it is just an error.
There was a problem hiding this comment.
If the path API is not deprecated I would prefer to do the inverted implementation (just add the new URL API as an overlay of the path counterparts).
There was a problem hiding this comment.
The documentation actually got ahead of us here. It is "soft deprecated", indicating that will eventually be deprecated.
It may seem like splitting hairs but I think we should remain consistent with the annotations in the SDK. Once the SDK marks it deprecated (with a API_DEPRECATED macro, e.g.) then we can add the attribute here.
If you want to invert the implementation, that's fine with me. That's actually how we do it in the ObjC Foundation too.
|
Final request: #1462 |
