Skip to content

Added URL API to Foundation.Process #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Added URL API to Foundation.Process #1462

wants to merge 5 commits into from

Conversation

pvieito
Copy link
Contributor

@pvieito pvieito commented Mar 6, 2018

Refs #1461

pvieito added 2 commits March 11, 2018 17:48
CFArray._nsObject already contains String elements so bridging them to
NSString crashes on Linux.

Also, enabled option to retrieve “AppleLanguages” list from preferences
plist in Linux.
@pvieito
Copy link
Contributor Author

pvieito commented Mar 11, 2018

I've also added a small fix to Locale static properties that produced crashes on Linux by bridging String to NSString.

@pushkarnk
Copy link
Member

@swift-ci please test

1 similar comment
@alblue
Copy link
Contributor

alblue commented Mar 12, 2018

@swift-ci please test

@pvieito
Copy link
Contributor Author

pvieito commented Mar 12, 2018

@swift-ci please test

Copy link
Contributor

@millenomi millenomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have (problematic) NSLocale/Locale changes intermixed with this patch; can you separate?

@@ -84,11 +84,11 @@ open class NSLocale: NSObject, NSCopying, NSSecureCoding {
}

extension NSLocale {
open class var current: Locale {
open static var current: Locale {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why static? This doesn't match the Darwin signature:

class var current: Locale { get }

return CFLocaleCopyCurrent()._swiftObject
}

open class var system: Locale {
open static var system: Locale {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above for all static members. Please revert?

@pvieito
Copy link
Contributor Author

pvieito commented Mar 12, 2018

Ups, sorry, didn't think about that. I will resend two separated pull requests.

@pvieito pvieito closed this Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants