-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Added URL API to Foundation.Process #1462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CFArray._nsObject already contains String elements so bridging them to NSString crashes on Linux. Also, enabled option to retrieve “AppleLanguages” list from preferences plist in Linux.
I've also added a small fix to Locale static properties that produced crashes on Linux by bridging String to NSString. |
@swift-ci please test |
1 similar comment
@swift-ci please test |
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you have (problematic) NSLocale/Locale changes intermixed with this patch; can you separate?
@@ -84,11 +84,11 @@ open class NSLocale: NSObject, NSCopying, NSSecureCoding { | |||
} | |||
|
|||
extension NSLocale { | |||
open class var current: Locale { | |||
open static var current: Locale { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why static
? This doesn't match the Darwin signature:
class var current: Locale { get }
return CFLocaleCopyCurrent()._swiftObject | ||
} | ||
|
||
open class var system: Locale { | ||
open static var system: Locale { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above for all static
members. Please revert?
Ups, sorry, didn't think about that. I will resend two separated pull requests. |
Refs #1461