Skip to content

[cmake] Fix capitalization in find_path argument. #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

drodriguez
Copy link
Contributor

/cc @compnerd

@compnerd
Copy link
Member

compnerd commented Nov 3, 2018

sigh typing is hard

@compnerd
Copy link
Member

compnerd commented Nov 3, 2018

We need to replicate this into the CF copy as well.

@drodriguez
Copy link
Contributor Author

Since I removed the duplicated script in #1746, I suppose this is the only change needed. But if you want the duplicated script, I can duplicate this change easily.

@compnerd
Copy link
Member

compnerd commented Nov 5, 2018

@swift-ci please test and merge

@drodriguez
Copy link
Contributor Author

The failure seems unrelated to this changes. I think I have seen the same test failing in another completely unrelated PR. Can we restart the tests? Thanks.

@milseman
Copy link
Member

milseman commented Nov 8, 2018

@swift-ci please test and merge

@milseman
Copy link
Member

milseman commented Nov 9, 2018

@swift-ci please test linux platform

@milseman milseman merged commit 42fa92c into swiftlang:master Nov 9, 2018
@drodriguez drodriguez deleted the typo-find-icu branch November 9, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants