[cmake] Find ICU in CoreFoundation. #1746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spevans already fixed this. We should however pass down the |
|
Should probably keep the addition of |
The patch passes the ICU_ROOT from the top level CMakeList.txt into the CoreFoundation one and performs a find_package to find the right include path. It also uses the Find ICU script from the top level, instead of the duplicated script (which has been removed).
drodriguez
force-pushed
the
cmake-icu-to-core-foundation
branch
from
b421c69 to
212e3ab
Compare
|
I hope this was what you both were intending: I removed the duplicated script and I passed |
compnerd
approved these changes
Nov 5, 2018
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
|
This seems to be causing an issue on PR testing: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/6459/changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICU is also included in CoreFoundation, but the include paths were
not used, which meant that the headers were probably the system
headers, if they were there. This might have work in Ubuntu, but
might not work in other systems with older ICUs.
The patch passes the ICU_ROOT from the top level CMakeList.txt into
the CoreFoundation one and performs a find_package to find the right
include path.
/cc @compnerd