Skip to content

[cmake] Find ICU in CoreFoundation. #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ ExternalProject_Add(CoreFoundation
-DCF_ENABLE_LIBDISPATCH=${FOUNDATION_ENABLE_LIBDISPATCH}
-DCF_PATH_TO_LIBDISPATCH_SOURCE=${FOUNDATION_PATH_TO_LIBDISPATCH_SOURCE}
-DCF_PATH_TO_LIBDISPATCH_BUILD=${FOUNDATION_PATH_TO_LIBDISPATCH_BUILD}
-DICU_INCLUDE_DIR=${ICU_INCLUDE_DIR}
-DICU_ROOT=${ICU_ROOT}
INSTALL_COMMAND
${CMAKE_COMMAND} -E env --unset=DESTDIR ${CMAKE_COMMAND} --build . --target install)
ExternalProject_Get_Property(CoreFoundation install_dir)
Expand Down
6 changes: 3 additions & 3 deletions CoreFoundation/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@

cmake_minimum_required(VERSION 3.4.3)
list(APPEND CMAKE_MODULE_PATH
"${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules")
"${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules"
"${CMAKE_CURRENT_SOURCE_DIR}/../cmake/modules")

project(CoreFoundation
VERSION
Expand Down Expand Up @@ -355,7 +356,7 @@ if(CMAKE_SYSTEM_NAME STREQUAL Linux OR CMAKE_SYSTEM_NAME STREQUAL Android)
find_package(ICU COMPONENTS uc i18n REQUIRED)
target_include_directories(CoreFoundation
PRIVATE
${ICU_INCLUDE_DIR})
${ICU_INCLUDE_DIRS})
else()
target_include_directories(CoreFoundation
PRIVATE
Expand Down Expand Up @@ -455,4 +456,3 @@ if(CF_ENABLE_LIBDISPATCH)
${CF_PATH_TO_LIBDISPATCH_SOURCE}/src/BlocksRuntime)
endif()
endif()

251 changes: 0 additions & 251 deletions CoreFoundation/cmake/modules/FindICU.cmake

This file was deleted.