TestFoundation: use .standardizingPath for normalization
#2010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than use `realpath` which is not universally available, use `.standardizingPath` which should normalize the path as `realpath` on all the targets since we are testing `Process` rather than `FileManager`.
|
CC: @millenomi @spevans |
|
@swift-ci please test |
|
Agreed, we shouldn't use any per-platform system calls in the tests, better to use something provided by Foundation itself to ensure it gets extra testing. |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than use
realpathwhich is not universally available, use.standardizingPathwhich should normalize the path asrealpathonall the targets since we are testing
Processrather thanFileManager.