[SR-9887] HTTPCookie on Linux does not accept Substring values #2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
pushkarnk
requested changes
Mar 20, 2019
Foundation/HTTPCookie.swift
Outdated
| if let str = strVal as? String { | ||
| return str | ||
| } else if let subStr = strVal as? Substring { | ||
| return String(_: subStr) |
There was a problem hiding this comment.
This could just be String(subStr)
Foundation/HTTPCookie.swift
Outdated
| @@ -377,6 +377,15 @@ open class HTTPCookie : NSObject { | |||
| } | |||
| } | |||
|
|
|||
| private class func getStringValue(strVal: Any?) -> String? { | |||
There was a problem hiding this comment.
Three suggestions here:
- Though this function name serves the purpose, we could shorten it, may be something like
stringValue. Just a suggestion :) - Could this function be nested inside the initialiser where it is being used?
- Because we only seem to be adding support for Substrings, do we really need the
strVal as? Stringcheck?
saiHemak
force-pushed
the
http-cookie
branch
3 times, most recently
from
dc54a7a to
24070d6
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
pushkarnk
approved these changes
Mar 21, 2019
Foundation/HTTPCookie.swift
Outdated
| @@ -377,6 +377,15 @@ open class HTTPCookie : NSObject { | |||
| } | |||
| } | |||
|
|
|||
| private class func getStringValue(strVal: Any?) -> String? { | |||
There was a problem hiding this comment.
I think the method signature would read better if it is updated something like this getStringValue(_ strValue: Any?)
There was a problem hiding this comment.
the words StringValue in the method name and the strVal parameter label reads redundant.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTPCookie initializer takes values as
Anybut fails to create cookie when Substring is passed to it. Casting fromSubstringto String returnsnildue to which the initializer is failing silently.