[4.2] JSONSerialization: fix a crash when an escape sequence contains low-s… #2027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrogate code point without the corresponding high-surrogate code point (cherry picked from commit 9eca3c0)
|
@swift-ci test 4.2 |
spevans
changed the title
|
@millenomi/@spevans I think that one is quite important so I think we could make a release for this soonish, let’s see if there are other important issues like this one coming in. We should definitely also propose this PR for Swift 5. We’re starting to gear up the monthlies for Swift 5 🙌 |
|
@millenomi This one is already in 5.0, for all my cherry-picks to 4.2 I made sure they came from 5.0 @weissi I have a use after free to backport to 5.0 and potentially 4.2 #2038 and a leak from #1540 which might also be worth doing if there is going to be one last 4.2 release. |
|
@spevans Please send 'em. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…urrogate code point without the corresponding high-surrogate code point
(cherry picked from commit 9eca3c0)